-
Notifications
You must be signed in to change notification settings - Fork 81
refactor: use SmtForest in SqliteStore
#1526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juan518munoz
commented
Nov 14, 2025
Contributor
|
Without having looked at the code - is this more about using the in-memory |
Collaborator
Author
|
It's about the first, replacing the current in memory merkle store with a (also in memory) smt forest. It may be a good idea if a subsequent PR implements the later tho. |
Collaborator
Author
|
Downgrading to draft until #1570 gets merged. |
igamigo
approved these changes
Jan 17, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces
MerkleStorewithSmtForest.Additionally wraps it over a new
AccountSmtForeststruct, which tracks active account SMTs (vault and storage maps) for any of the latest account states (and caches pending state SMTs as well in case we need to rollback)